Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check database sslmode when validating schema #535

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Check database sslmode when validating schema #535

merged 3 commits into from
Aug 23, 2024

Conversation

GMKrieger
Copy link
Contributor

@GMKrieger GMKrieger commented Jul 26, 2024 •
edited
Loading

Closes #412

@GMKrieger GMKrieger added the #feat:db Feature: database label Jul 26, 2024
@GMKrieger GMKrieger self-assigned this Jul 26, 2024
@marcelstanley marcelstanley requested review from a team and marcelstanley August 2, 2024 21:15
@marcelstanley
Copy link
Collaborator

I'd suggest changing chore: remove obsolete config from yaml files to chore(build): remove obsolete compose config

@marcelstanley marcelstanley requested a review from a team August 2, 2024 21:21
vfusco
vfusco requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@vfusco vfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @marcelstanley 's comment

@marcelstanley marcelstanley added this to the 2.0.0 milestone Aug 13, 2024
@GMKrieger GMKrieger changed the title Check if is devnet when validating schema Check database sslmode when validating schema Aug 14, 2024
fmoura
fmoura previously approved these changes Aug 15, 2024
View reviewed changes
marcelstanley
marcelstanley requested changes Aug 15, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/compose-devnet.yaml Show resolved Hide resolved
internal/node/config/generate/Config.toml Outdated Show resolved Hide resolved
@GMKrieger GMKrieger force-pushed the feature/update-startup branch 2 times, most recently from 70e99ef to eb18feb Compare August 19, 2024 16:03
fmoura
fmoura requested changes Aug 19, 2024
View reviewed changes
internal/node/config/generate/Config.toml Outdated Show resolved Hide resolved
fmoura
fmoura reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@fmoura fmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But there is an error on Github Actions

@GMKrieger GMKrieger merged commit 3a8278a into next/2.0 Aug 23, 2024
6 checks passed
@GMKrieger GMKrieger deleted the feature/update-startup branch August 23, 2024 14:26
@GMKrieger GMKrieger mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoura fmoura fmoura approved these changes

@vfusco vfusco vfusco approved these changes

@marcelstanley marcelstanley marcelstanley approved these changes

Assignees

@GMKrieger GMKrieger

Labels
#feat:db Feature: database
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GMKrieger @marcelstanley @fmoura @vfusco