Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sslmode configuration to startup #412

Closed
2 tasks
Tracked by #375
GMKrieger opened this issue May 15, 2024 · 0 comments
Closed
2 tasks
Tracked by #375

Add sslmode configuration to startup #412

GMKrieger opened this issue May 15, 2024 · 0 comments
Assignees
Labels
#feat:go-supervisor Feature: Go supervisor
Milestone

Comments

@GMKrieger
Copy link
Contributor

GMKrieger commented May 15, 2024

📚 Context

During development, a conflict occurred on how to correctly deploy the migrations. The local database we run is not enabled with ssl, and does not require certificates, different from the production database. The migrations driver requires a command to inform if the database is configured with ssl or not, and will not perform if this configuration is wrong.

The problem is even deployed to production with the correct configuration, the tests will break, as the database used for the tests does not used ssl, as well. There needs to be a way to differentiate when to use the sslmode.

✔️ Solution

The Node needs to know to where it's being deployed, either locally or production. There are 2 ways to this: either the Node is said explicitly, and there needs to be flag to tell it, or it needs to check certain configurations that are known to be different and infer the deployment.

The second solution is leaner and avoids bogging the startup command, but runs the risk of breaking in the future if the configuration changes and the check is not performed correctly.

From the moment of writing this issue, there isn't an obvious path to follow. Part of the work needed is studying the Node and convening with the team to chose a way to move forward.

📈 Subtasks

  • Find a method to differentiate local and production startups
  • Add the different ssl mode configuration to each startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:go-supervisor Feature: Go supervisor
Projects
Status: Done
Development

No branches or pull requests

2 participants