Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #106

Closed
kinow opened this issue Jan 31, 2023 · 2 comments
Closed

Add CONTRIBUTING.md #106

kinow opened this issue Jan 31, 2023 · 2 comments
Assignees
Labels
joss Issues related to the JOSS paper submission

Comments

@kinow
Copy link

kinow commented Jan 31, 2023

Hi,

At the end of the README file there's some information for contributors, but perhaps this could be expanded to provide users with a clear and simple way to contribute. It should include what contributions are welcome (as is in the README file), how to build and what to build Carnival, if tests are expected, what type of test, any community guidelines (CLA, policies, etc), and anything else that might be helpful to contributors.

This is related to the JOSS paper review item:

Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

@hjwilli hjwilli self-assigned this Feb 2, 2023
@th5 th5 added the joss Issues related to the JOSS paper submission label Feb 3, 2023
hjwilli added a commit that referenced this issue May 11, 2023
@hjwilli
Copy link
Collaborator

hjwilli commented May 11, 2023

Hi @kinow, CONTRIBUTIONS.md has been added, please let us know if this is sufficient.

@kinow
Copy link
Author

kinow commented May 11, 2023

Hi @kinow, CONTRIBUTIONS.md has been added, please let us know if this is sufficient.

Yes! Thank you @hjwilli ! Closing.

@kinow kinow closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss Issues related to the JOSS paper submission
Projects
None yet
Development

No branches or pull requests

3 participants