Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some deprecations #795

Merged
merged 3 commits into from
Oct 19, 2017
Merged

Remove some deprecations #795

merged 3 commits into from
Oct 19, 2017

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Oct 19, 2017

  • Remove Filter.name deprecation code
  • Remove deprecation tests
  • Fixup tests to use Filter.field_name

@rpkilby rpkilby mentioned this pull request Oct 19, 2017
Merged
2 tasks
@codecov-io
Copy link

codecov-io commented Oct 19, 2017 •
edited
Loading

Codecov Report

Merging #795 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #795      +/-   ##
===========================================
- Coverage    97.56%   97.54%   -0.03%     
===========================================
  Files           15       15              
  Lines         1234     1222      -12     
===========================================
- Hits          1204     1192      -12     
  Misses          30       30
Impacted Files Coverage Δ
django_filters/filters.py 97.28% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0148e57...f400878. Read the comment docs.

@carltongibson carltongibson merged commit 5691fee into carltongibson:develop Oct 19, 2017
@carltongibson carltongibson added this to the Version 2.0 milestone Oct 19, 2017
@rpkilby rpkilby deleted the remove-deprecations branch October 19, 2017 09:34
carltongibson pushed a commit that referenced this pull request Oct 24, 2017
@carltongibson
[2.x] Remove some deprecations (#795)
dd4795c 
* Remove deprecation tests

* Remove 'Filter.name' deprecation

* Fixup 'Filter.field_name' in tests
carltongibson pushed a commit that referenced this pull request Oct 24, 2017
@carltongibson
[2.x] Remove some deprecations (#795)
9c28903 
* Remove deprecation tests

* Remove 'Filter.name' deprecation

* Fixup 'Filter.field_name' in tests
@rpkilby rpkilby changed the title [2.x] Remove some deprecations Remove some deprecations Jan 27, 2018
@rpkilby rpkilby mentioned this pull request Jun 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rpkilby @codecov-io @carltongibson