-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'Meta.together' option #791
Remove 'Meta.together' option #791
Conversation
hehe. You're Psychic. Yes. I'd take this. 😃 Aside: the general thing I'm aiming for is less magic rather than more. I want to guide people towards overriding the form class etc. There is already "one correct way to do things". It just needs highlighting. My Autumn Project™ is the long-awaited reworking of the documentation, to this effect. |
If you wanted to tick off those TODOs now, I'd take this for 1.1...? (no stress if not, there's no rush for it.) |
Hmmmm. how about a simple deprecation warning for the together option? Give me ~10 minutes |
ie, add a deprecation warning for 1.1, remove in 2.0 |
Yep. That would be fine. (That's sort of what I meant really — best not to just break it... 🙃) |
00f1b3c
to
70f43e9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
- Coverage 97.54% 97.42% -0.13%
===========================================
Files 15 15
Lines 1222 1202 -20
===========================================
- Hits 1192 1171 -21
- Misses 30 31 +1
Continue to review full report at Codecov.
|
70f43e9
to
8c30555
Compare
This is basically ready to go, but needs to be rebased off of #795 |
8c30555
to
01a1f67
Compare
is it in the docs somewhere? I couldn't find anything related to this. #1167 is something similar but doesn't seem like it's going to be merged |
Ah, my long standing todo, yes. Did you see the last comment on the linked PR? |
Especially given that the #784 was rejected, I'm somewhat inclined to remove the
Meta.together
option, and replace it with aForm.clean
example in the docs (which would also cover exclusive filter handling).TODO:
Add docs example forForm.clean
together/exclusive handling