Skip to content

Don't write back to the same input we read from; seems to cause deadlock #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't write back to the same input we read from; seems to cause deadlock #2088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions hydra-node/src/Hydra/Node.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ hydrate ::
[EventSink (StateEvent tx) m] ->
m (DraftHydraNode tx m)
hydrate tracer env ledger initialChainState EventStore{eventSource, eventSink} eventSinks = do
let allSinks = eventSink : eventSinks
traceWith tracer LoadingState
(lastEventId, (headState, chainStateHistory)) <-
runConduitRes $
Expand All @@ -203,7 +202,7 @@ hydrate tracer env ledger initialChainState EventStore{eventSource, eventSink} e
-- (Re-)submit events to sinks; de-duplication is handled by the sinks
traceWith tracer ReplayingState
runConduitRes $
sourceEvents eventSource .| mapM_C (\e -> lift $ putEventsToSinks allSinks [e])
sourceEvents eventSource .| mapM_C (\e -> lift $ putEventsToSinks eventSinks [e])

nodeState <- createNodeState (getLast lastEventId) headState
inputQueue <- createInputQueue
Expand All @@ -215,7 +214,7 @@ hydrate tracer env ledger initialChainState EventStore{eventSource, eventSink} e
, nodeState
, inputQueue
, eventSource
, eventSinks = allSinks
, eventSinks = eventSink : eventSinks
, chainStateHistory
}
where
Expand Down