fix(tabs): updates role to tab and moves aria-selected to li #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit a3fc50e https://deploy-preview-4451--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit a3fc50e |
|
Deploy preview for carbon-components-react ready! Built with commit a3fc50e https://deploy-preview-4451--carbon-components-react.netlify.com |
|
Retested with DAP Sept 2019 WCAG 2.1 ruleset and there are no violations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1942
This was done during the mob programming by @aledavila and me! 🎉
It updates the role of the
liin each tab totabso thataria-selectedbecomes valid aria. It also addsaria-disabledon disabled tabs.Changelog
Changed
role="presentation"->role="tab"Removed
aria-selectedon theaTesting / Reviewing
Run DAP on the vanilla Tabs component and verify that there an no violations associated with the component (there will be some coming from the environment so ignore those)