fix: updates role to tab and moves aria-selected to li (#4451)

carbon-design-system · Oct 24, 2019 · 9c354fa · 9c354fa
1 parent 0dd565e
commit 9c354fa
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/components/src/components/tabs/tabs.hbs b/packages/components/src/components/tabs/tabs.hbs
@@ -14,9 +14,10 @@
     {{#each items}}
     <li
       class="{{@root.prefix}}--tabs__nav-item{{#if selected}} {{@root.prefix}}--tabs__nav-item--selected{{/if}} {{#if disabled}} {{@root.prefix}}--tabs__nav-item--disabled {{/if}}"
-      data-target=".{{panelClass}}" role="presentation">
+      data-target=".{{panelClass}}" role="tab" {{#if selected}} aria-selected="true" {{/if}} {{#if disabled}}
+      aria-disabled="true" {{/if}}>
       <a tabindex="0" id="{{linkId}}" class="{{@root.prefix}}--tabs__nav-link" href="javascript:void(0)" role="tab"
-        aria-controls="{{panelId}}" {{#if selected}} aria-selected="true" {{/if}}>{{label}}</a>
+        aria-controls="{{panelId}}">{{label}}</a>
     </li>
     {{/each}}
   </ul>
@@ -29,4 +30,4 @@
     <p style="padding: 0 1rem; font-size: 14px; font-weight: 600;">{{panelContent}}</p>
   </div>
   {{/each}}
-</div>
+</div>