fix(date-picker): disable mobile UI #4443
Conversation
This change disables `flatpickr`'s mobile mode, given we have been not supporting the mobile UI and the mobile UI has caused several JavaScript errors. Fixes carbon-design-system#4420.
|
Deploy preview for the-carbon-components ready! Built with commit 53300d7 https://deploy-preview-4443--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 53300d7 https://app.netlify.com/sites/carbon-components-react/deploys/5dbc669f635e2aafe0e976f7 |
|
Deploy preview for carbon-elements failed. Built with commit 53300d7 https://app.netlify.com/sites/carbon-elements/deploys/5db381a484f6030008e6e911 |
ghost
requested review from
|
@jeanservaas talking with @joshblack, it seems like we just wanted to verify on the UX design side if we want to disable the MobileUI for the DatePicker. |
|
@jeanservaas I think what you are seeing may be what is intended. It seems like in the past flatpickr had a mobile view that this PR gets rid of to create that screenshot you posted |
|
Sorry for not being clear enough @jeanservaas - @abbeyhrt and @joshblack are right, Flatpickr has different look for mobile. We haven't supported that mode, but in the status quo, whenever user goes to mobile such mobile mode is activated, causing several bugs, notably you'll see something below in some conditions (this is browser's native date picker):
So we want to ensure mobile mode is never activated. |
|
@emyarod You have good question, native date picker may be in (future) consideration if we can style it in the way we want. Same thing applies to sliders, etc, too (in my personal opinion). |
This change disables
flatpickr's mobile mode, given we have been notsupporting the mobile UI and the mobile UI has caused several
JavaScript errors.
Fixes #4420.
Changelog
New
flatpick's mobile mode.Testing / Reviewing
Testing should make sure our date picker is not broken.