Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UIShell): omit passing isSideNavExpanded prop to Link component #4349

Merged
merged 9 commits into from
Oct 22, 2019
Merged

fix(UIShell): omit passing isSideNavExpanded prop to Link component #4349

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5dbc09f
fix(react): omt passing isSideNavExpanded prop in Link component
Oct 16, 2019
deb394c
fix(react): omit passing isSideNavExpanded prop in Link component
Oct 16, 2019
505e855
Merge branch 'fix/sidenavexpanded' of https://github.com/metonym/carb…
Oct 16, 2019
67d69a1
fix(react): use eslint-disable-next-line scope
metonym Oct 16, 2019
42d41ee
fix(react): remove eslint comment syntax
metonym Oct 17, 2019
a623b04
Merge branch 'master' into fix/sidenavexpanded
joshblack Oct 21, 2019
116a0ad
Merge branch 'master' into fix/sidenavexpanded
asudoh Oct 22, 2019
9c99344
chore(ui shell): re-run prettier
Oct 22, 2019
d518978
Merge branch 'master' into fix/sidenavexpanded
joshblack Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react/src/components/UIShell/SideNavLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ import SideNavLinkText from './SideNavLinkText';

const { prefix } = settings;

/* eslint-disable no-unused-vars */
metonym marked this conversation as resolved.
Show resolved Hide resolved

const SideNavLink = ({
className: customClassName,
children,
renderIcon: IconElement,
isActive,
large,
// eslint-disable-next-line no-unused-vars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update; BTW I thought https://twitter.com/dan_abramov/status/838576620235550720 is applied to our ESLint config. Did you see it's not the case...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I pushed the first commit, I didn't disable any eslint rules. I ran "yarn ci-check" on my local machine and then faced the error "no-unused-vars."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair enough - Thank you for clarifying!

isSideNavExpanded,
metonym marked this conversation as resolved.
Show resolved Hide resolved
...rest
}) => {
const className = cx({
Expand Down