fix(UIShell): omit passing isSideNavExpanded prop to Link component
#4349
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 5dbc09f https://deploy-preview-4349--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 5dbc09f |
|
Deploy preview for carbon-components-react failed. Built with commit 5dbc09f https://app.netlify.com/sites/carbon-components-react/deploys/5da7249f2d583a00076d5715 |
|
Deploy preview for the-carbon-components ready! Built with commit d518978 https://deploy-preview-4349--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit d518978 |
|
Deploy preview for carbon-components-react ready! Built with commit d518978 https://deploy-preview-4349--carbon-components-react.netlify.com |
Co-Authored-By: Josh Black <josh@josh.black>
metonym
changed the title
isSideNavExpanded prop to Link component
Co-Authored-By: Akira Sudoh <asudoh@gmail.com>
| const SideNavLink = ({ | ||
| className: customClassName, | ||
| children, | ||
| renderIcon: IconElement, | ||
| isActive, | ||
| large, | ||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
Thank you for the update; BTW I thought https://twitter.com/dan_abramov/status/838576620235550720 is applied to our ESLint config. Did you see it's not the case...?
There was a problem hiding this comment.
Before I pushed the first commit, I didn't disable any eslint rules. I ran "yarn ci-check" on my local machine and then faced the error "no-unused-vars."
There was a problem hiding this comment.
OK, fair enough - Thank you for clarifying!
| const SideNavLink = ({ | ||
| className: customClassName, | ||
| children, | ||
| renderIcon: IconElement, | ||
| isActive, | ||
| large, | ||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
OK, fair enough - Thank you for clarifying!
|
@metonym Would you be able to re-run Prettier? Thanks! |
|
The UiShell SideNav behavior is fixed in 10.7.1 . |
Closes #4348
Omit passing
isSideNavExpandedprop by destructuring it in props.Changelog
Changed
isSideNavExpandedpropTesting / Reviewing
In the React workspace, run
yarn startto start the storybook locally. Navigate to the UI Shell header base w/ sidenav story. Open the console; the React warning should not be emitted.