Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressIndicator): remove role attribute from checkmark svg #4255

Merged
merged 3 commits into from
Oct 9, 2019
Merged

fix(ProgressIndicator): remove role attribute from checkmark svg #4255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd100e8
fix(ProgressIndicator): remove `role` attribute from checkmark svg
emyarod Oct 8, 2019
a841b94
fix(ProgressIndicator): add aria-disabled attribute to disabled steps
emyarod Oct 8, 2019
1d6d2e0
Merge branch 'master' into 4243-progress-indicator-dap-violations
asudoh Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/components/ProgressIndicator/ProgressIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const ProgressStep = ({ ...props }) => {
}
if (complete) {
return (
<CheckmarkOutline16 role="img">
<CheckmarkOutline16>
<title>{description}</title>
</CheckmarkOutline16>
);
Expand All @@ -71,7 +71,7 @@ export const ProgressStep = ({ ...props }) => {
};

return (
<li className={classes}>
<li className={classes} aria-disabled={disabled}>
<div
className={classnames(`${prefix}--progress-step-button`, {
[`${prefix}--progress-step-button--unclickable`]: !onClick || current,
Expand Down