fix(ProgressIndicator): remove role attribute from checkmark svg
#4255
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 1d6d2e0 https://deploy-preview-4255--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 1d6d2e0 https://deploy-preview-4255--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 1d6d2e0 |
| <path d="M 7, 7 m -7, 0 a 7,7 0 1,0 14,0 a 7,7 0 1,0 -14,0" /> | ||
| <title>{description}</title> | ||
| </svg> | ||
| ); | ||
| } | ||
| if (complete) { | ||
| return ( | ||
| <CheckmarkOutline16 role="img"> | ||
| <CheckmarkOutline16 role="img" {...rest}> |
There was a problem hiding this comment.
Since the icons are aria-hidden by default, i believe, instead of adding {...rest} it might be better to remove role="img" and the aria-label added to SVGIcon. Since label is used twice, VO reads it twice and no longer reads the description. This change also removes the DAP violation.
There was a problem hiding this comment.
removed the role attribute and reverted aria-label changes
emyarod
force-pushed
the
4243-progress-indicator-dap-violations
branch
from
82bf947 to
a841b94
Compare
emyarod
changed the title
role attribute from checkmark svg
Closes #4243
This PR removes the
roleattribute from completed progress steps and adds thearia-disabledattribute to disabled progress stepsTesting / Reviewing
Ensure the reported DAP violations are no longer present in the progress indicator component