chore(a11y): update accessibility-checker to v3.1.74 #17128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
commented
Aug 8, 2024
achecker.js
Outdated
| @@ -10,7 +10,7 @@ | |||
| const path = require('path'); | |||
|
|
|||
| module.exports = { | |||
| ruleArchive: 'latest', | |||
| ruleArchive: 'versioned', | |||
There was a problem hiding this comment.
This makes sure we use a rule pack that matches the version of accessibility-checker we're currently on. New rulesets will only be brought in by updating accessibility-checker, so no more randomly failing CI checks out of the blue after a new ruleset is published on latest.
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2nikhiltom
approved these changes
Aug 9, 2024
|
Here it is why @tay1orjones |
emyarod
approved these changes
Aug 9, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 9, 2024
76ebd21
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates accessibility-checker to the latest.
I'm not sure why renovate hasn't been keeping this up to date. @guidari any ideas? 🤔
Changelog
Changed
Testing / Reviewing
06 August 2024ruleset here that we need to fix in order to merge this