fix: change the HeaderMenuItem so it show docs in storybook #14617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
azizChebbi
added a commit
to azizChebbi/carbon
that referenced
this pull request
Sep 9, 2023
pull request carbon-design-system#14617 already opened for this file, I pushed it by mistake.
guidari
approved these changes
Sep 12, 2023
|
@guidari glad to hear that ❤️ |
alisonjoseph
approved these changes
Sep 12, 2023
|
@azizChebbi another small merge conflict, then it's good to go. Thanks for your contributions! |
auto-merge was automatically disabled
September 12, 2023 18:11
Head branch was pushed to by a user without write access
Merged
via the queue into
carbon-design-system:main
with commit Sep 12, 2023
3cfbc24
17 checks passed
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…esign-system#14617) Co-authored-by: TJ Egan <tw15egan@gmail.com>
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…esign-system#14617) Co-authored-by: TJ Egan <tw15egan@gmail.com>
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…esign-system#14617) Co-authored-by: TJ Egan <tw15egan@gmail.com>
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…esign-system#14617) Co-authored-by: TJ Egan <tw15egan@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
* refactor(ComboBox): improve TS types * chore(ComboBox): fix file formatting * fix(react): uishell headermenu blur handler (#14616) Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> * fix: add isSelected prop to IconButton (#14600) * fix: add isSelected prop to IconButton * fix: update snapshot * fix: change the HeaderMenuItem so it show docs in storybook (#14617) Co-authored-by: TJ Egan <tw15egan@gmail.com> * fix(contributors): remove duplicate contributors * test(snapshot): update snapshots --------- Co-authored-by: cordesmj <cordesmj@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: Aziz Chebbi <60013060+azizChebbi@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14146
I changed the component declaration(types) so it shows docs in Storybook.
Changelog
New
Changed