Skip to content

Commit

Permalink
Improve typescript types for ComboBox component (#14576)
Browse files Browse the repository at this point in the history
* refactor(ComboBox): improve TS types

* chore(ComboBox): fix file formatting

* fix(react): uishell headermenu blur handler (#14616)

Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>

* fix: add isSelected prop to IconButton (#14600)

* fix: add isSelected prop to IconButton

* fix: update snapshot

* fix: change the HeaderMenuItem so it show docs in storybook (#14617)

Co-authored-by: TJ Egan <tw15egan@gmail.com>

* fix(contributors): remove duplicate contributors

* test(snapshot): update snapshots

---------

Co-authored-by: cordesmj <cordesmj@users.noreply.github.com>
Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Co-authored-by: Aziz Chebbi <60013060+azizChebbi@users.noreply.github.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
  • Loading branch information
5 people authored Sep 20, 2023
1 parent c939468 commit cfad9d4
Show file tree
Hide file tree
Showing 4 changed files with 517 additions and 422 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,15 @@
"contributions": [
"code"
]
},
{
"login": "misiekhardcore",
"name": "Michał Konopski",
"avatar_url": "https://avatars.githubusercontent.com/u/58469680?v=4",
"profile": "https://github.com/misiekhardcore",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
<td align="center"><a href="https://github.com/haocheng6"><img src="https://avatars.githubusercontent.com/u/7645930?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Hao Cheng</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=haocheng6" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/cordesmj"><img src="https://avatars.githubusercontent.com/u/7409239?v=4?s=100" width="100px;" alt=""/><br /><sub><b>cordesmj</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=cordesmj" title="Code">💻</a></td>
<td align="center"><a href="https://med-aziz-chebbi.web.app/"><img src="https://avatars.githubusercontent.com/u/60013060?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Aziz Chebbi</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=azizChebbi" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/misiekhardcore"><img src="https://avatars.githubusercontent.com/u/58469680?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Michał Konopski</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=misiekhardcore" title="Code">💻</a></td>
</tr>
</table>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,7 @@ Map {
"type": "shape",
},
"helperText": Object {
"type": "string",
"type": "node",
},
"id": Object {
"isRequired": true,
Expand Down
Loading

0 comments on commit cfad9d4

Please sign in to comment.