Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icons): story icons no longer shrink to fit container #12568

Merged
merged 5 commits into from
Nov 9, 2022
Merged

fix(Icons): story icons no longer shrink to fit container #12568

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
661628e
feat: merge from upstream
jnm2377 Nov 8, 2022
31fe2c5
fix: increase icon story width to unshrink icons
jnm2377 Nov 8, 2022
1c3b26c
Revert "feat: merge from upstream"
jnm2377 Nov 8, 2022
e833944
fix: add min width to svg
jnm2377 Nov 8, 2022
6de4a0b
Merge branch 'main' into fix-icons-story
tw15egan Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/Icons/Icons.stories.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//
.demo-icon-example {
display: flex;
width: 10rem;
width: 15rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also be helpful to set a min-width on the svg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw15egan that's a good call. better safe than sorry. 👍🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw15egan pushed an update. lmk if you think I should revert the original width to 10rem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, can't hurt to have both. Thanks for fixing this!

justify-content: space-between;
margin: 2rem;
}