fix(Icons): story icons no longer shrink to fit container #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This reverts commit 661628e.
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alisonjoseph
approved these changes
Nov 8, 2022
tw15egan
reviewed
Nov 8, 2022
| @@ -6,7 +6,7 @@ | |||
| // | |||
| .demo-icon-example { | |||
| display: flex; | |||
| width: 10rem; | |||
| width: 15rem; | |||
There was a problem hiding this comment.
Would it also be helpful to set a min-width on the svg?
There was a problem hiding this comment.
@tw15egan that's a good call. better safe than sorry. 👍🏽
There was a problem hiding this comment.
@tw15egan pushed an update. lmk if you think I should revert the original width to 10rem.
There was a problem hiding this comment.
Nah, can't hurt to have both. Thanks for fixing this!
tw15egan
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current icons story has a bug where the icons are much smaller than their actual sizes: https://react.carbondesignsystem.com/?path=/story/elements-icons--default this is because the wrapper has a set width, so the svgs are shrinking to fit that width.
Changelog
Testing / Reviewing