feat(Listbox): add in FluidComboBox, FluidMultiSelect
#12163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
force-pushed
the
fluid-listbox
branch
from
3a7bbc3 to
f6c1455
Compare
aagonzales
suggested changes
Oct 7, 2022
Contributor
There was a problem hiding this comment.
All 3 dropdowns
- Missing the border-bottom
$border-strongon thewarnstates
ComboBox
- Can we add the "Filter..." prompt text to the Combobox input
-
I wonder if we can shift the listbox down so the bottom border of the focus is still shown. Not a hill I'll die on just wondering if its possible.
tw15egan
force-pushed
the
fluid-listbox
branch
from
b8b42bb to
31fec9f
Compare
tw15egan
force-pushed
the
fluid-listbox
branch
from
0f1799a to
663696f
Compare
abbeyhrt
approved these changes
Oct 14, 2022
Contributor
Author
|
cc @aledavila |
aledavila
approved these changes
Oct 21, 2022
sstrubberg
added
status: merge conflict 🚫
and removed
status: ready for review 👀
status: one more review 👀
labels
tw15egan
force-pushed
the
fluid-listbox
branch
from
663696f to
cb61953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12120
Closes #12124
Refs #12128
Initial PR adding in
unstable__FluidComboBoxandunstable__FluidMultiSelect.Changelog
New
unstable__FluidComboBoxandunstable__FluidMultiSelectcomponentsFluidComboBox(_fluid-combo-box.scss),FluidMultiSelect(_fluid-multiselect.scss)FluidComboBox(FluidComboBox.stories.js) andFluidMultiSelect(FluidMultiSelect.stories.js)FluidComboBoxandFluidMultiSelectTesting / Reviewing
FluidMultiSelectandFluidComboBoxstories and ensure all styles are correct, all variants render as expected, and all playground controls work.FluidDropdown