Skip to content

Commit 31fec9f

Browse files
committed
fix(ListBox): make style changes based on feedback
1 parent a4c3f48 commit 31fec9f

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

packages/react/src/components/FluidComboBox/FluidComboBox.stories.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ const ToggleTip = (
6565
export const Default = () => (
6666
<div style={{ width: '400px' }}>
6767
<FluidComboBox
68+
placeholder="Filter..."
6869
onChange={() => {}}
69-
initialSelectedItem={items[2]}
7070
id="default"
7171
titleText="Label"
7272
label="Choose an option"
@@ -79,6 +79,7 @@ export const Default = () => (
7979
export const Condensed = () => (
8080
<div style={{ width: '400px' }}>
8181
<FluidComboBox
82+
placeholder="Filter..."
8283
onChange={() => {}}
8384
id="default"
8485
isCondensed
@@ -93,6 +94,7 @@ export const Condensed = () => (
9394
export const Playground = (args) => (
9495
<div style={{ width: args.playgroundWidth }}>
9596
<FluidComboBox
97+
placeholder="Filter..."
9698
onChange={() => {}}
9799
id="default"
98100
titleText="Label"
@@ -103,6 +105,7 @@ export const Playground = (args) => (
103105
/>
104106
<br />
105107
<FluidComboBox
108+
placeholder="Filter..."
106109
{...args}
107110
onChange={() => {}}
108111
id="default-3"

packages/styles/scss/components/fluid-list-box/_fluid-list-box.scss

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,12 @@
9595
outline-offset: 0;
9696
}
9797

98+
.#{$prefix}--list-box__wrapper--fluid
99+
:not(.#{$prefix}--list-box--up)
100+
.#{$prefix}--list-box__menu {
101+
top: calc(100% + rem(3px));
102+
}
103+
98104
// Invalid / Warning styles
99105
.#{$prefix}--list-box__wrapper--fluid.#{$prefix}--list-box__wrapper--fluid--invalid:not(.#{$prefix}--list-box__wrapper--fluid--focus) {
100106
@include focus-outline('invalid');
@@ -146,6 +152,12 @@
146152
margin-top: 0;
147153
}
148154

155+
.#{$prefix}--list-box__wrapper--fluid
156+
.#{$prefix}--list-box--warning
157+
~ .#{$prefix}--form-requirement {
158+
border-bottom: 1px solid $border-strong;
159+
}
160+
149161
.#{$prefix}--list-box__wrapper--fluid.#{$prefix}--list-box__wrapper--fluid--invalid
150162
.#{$prefix}--list-box__invalid-icon,
151163
.#{$prefix}--list-box__wrapper--fluid

0 commit comments

Comments
 (0)