fix(api,ui): Fix autoscaling target parsing #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2024 12:17
deadlycoconuts
force-pushed
the
fix_autoscaling_target_parsing
branch
from
6b65992 to
4e28f71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 62.15% 62.19% +0.04%
==========================================
Files 124 124
Lines 9747 9755 +8
==========================================
+ Hits 6058 6067 +9
- Misses 2953 2954 +1
+ Partials 736 734 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deadlycoconuts
force-pushed
the
fix_autoscaling_target_parsing
branch
from
4e28f71 to
48a8e16
Compare
deadlycoconuts
force-pushed
the
fix_autoscaling_target_parsing
branch
from
48a8e16 to
91396ad
Compare
deadlycoconuts
commented
May 9, 2024
ui/src/router/components/form/components/autoscaling_policy/AutoscalingPolicyPanel.js
Show resolved
Hide resolved
6 tasks
ariefrahmansyah
approved these changes
May 13, 2024
Contributor
Author
|
Thanks for the quick review @ariefrahmansyah ! Merging this now (oops I totally forgot about this hanging PR for over 2 weeks 🥲) |
ariefrahmansyah
pushed a commit
to caraml-dev/merlin
that referenced
this pull request
May 21, 2024
# Description This PR introduces a fix to address a tiny UI bug whereby a red line appears when an autoscaling target value that is outside the configured step size (e.g. 1.003 when the step size is 1) is set:  The fix implemented is exactly the same as what has been done for Turing here: caraml-dev/turing#380 (comment). # Modifications - `ui/src/pages/version/components/forms/components/AutoscalingPolicyFormGroup.js` - Update to some props passed to the `EuiFieldNumber` component # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a follow up on PR #378, which introduces additional fixes and some minor refactoring to make the UI and API server behaviour consistent with that of Merlin's, especially with regards to the handling of autoscaling target values.
In short, this PR does the following: