fix(ui): Update min and step size of autoscaling target field #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 60.31% 60.29% -0.02%
==========================================
Files 274 274
Lines 21930 21930
==========================================
- Hits 13226 13223 -3
- Misses 7855 7857 +2
- Partials 849 850 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ariefrahmansyah
approved these changes
May 13, 2024
deadlycoconuts
force-pushed
the
fix_ui_bug_showing_incorrect_autoscaling_target
branch
from
9031d6c to
08cd60e
Compare
Contributor
Author
|
Thanks for the quick review @ariefrahmansyah ! Merging this now! |
ariefrahmansyah
deleted the
fix_ui_bug_showing_incorrect_autoscaling_target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix to address a tiny UI bug whereby a red line appears when an autoscaling target value that is outside the configured step size (e.g. 1.003 when the step size is 1) is set:
The fix implemented is exactly the same as what has been done for Turing here: caraml-dev/turing#380 (comment).
Modifications
ui/src/pages/version/components/forms/components/AutoscalingPolicyFormGroup.js- Update to some props passed to theEuiFieldNumbercomponentTests
Checklist
Release Notes