Added static typing to data_readers/data_utils.py #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanketh7
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
| @@ -15,10 +17,10 @@ | |||
| from .. import dp_logging | |||
| from .filepath_or_buffer import FileOrBufferHandler, is_stream_buffer # NOQA | |||
|
|
|||
| logger = dp_logging.get_child_logger(__name__) | |||
| logger: Logger = dp_logging.get_child_logger(__name__) | |||
There was a problem hiding this comment.
if you import annotations from __futures__ can you not import the Logger here?
| @@ -1,10 +1,12 @@ | |||
| """Contains functions for data readers.""" | |||
| import json | |||
| from logging import Logger | |||
There was a problem hiding this comment.
might be able to get rid of this with annotations import from __futures__
| @@ -299,13 +301,14 @@ def read_csv_df( | |||
|
|
|||
| # if the buffer was wrapped, detach it before returning | |||
| if is_buf_wrapped: | |||
| assert isinstance(file_path, TextIOWrapper) | |||
There was a problem hiding this comment.
code change: is this required by mypy?
Sanketh7
force-pushed
the
data_utils_static_typing
branch
from
c7107fc
to
2cbde0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#610