-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Type Hinting: dataprofiler/data_readers/
#610
Comments
Because this folder is so large, I recommend making more PRs that are smaller (3 - 4 files at a time / keep the net diff number lower when possible). |
@Sanketh7 just these last three PRs and this will be complete? Is that right? |
There are 2 more files that need static typing but these are very short and I'll have a PR for them up soon. |
All merged. Closing. Thanks @Sanketh7 |
Is your feature request related to a problem? Please describe.
Improve the project in the area of
Describe the outcome you'd like:
Utilizing types from mypy documentation for python3, implement type hinting in the
dataprofiler/data_readers/
folder. In this case, because there are multiple files in the folder, at the very minimum the changes should be partitioned out into multiple Pull Requests (PRs). Potentially this could go so far as 1 PR --> 1 file update with type hints.Additional context:
The text was updated successfully, but these errors were encountered: