Invoke iterate() via async.setImmediate() in async.eachSeries() #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stack if the iterator function sometimes invokes the callback directly with 'return callback();'
|
Duplicate of #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the iterator function happens to invoke the callback and then return rather than invoking the callback from some further asynchronous call, which is common if it determines it is not interested in this particular item, the stack depth increases. If a large percentage of invocations do this, the stack will eventually crash. Wrapping the call to iterate() in async.setImmediate() resolves the issue, and seems more natural than requiring every instance of code that utilizes async.eachSeries() to wrap its direct invocations of the callback.