Use setImmediate to fix stack overflows in eachSeries.#296
Closed
mltucker wants to merge 2 commits into
Closed
Conversation
This fixes stack overflows on large lists in node.js.
|
Having the same issue with stack overflow. |
Contributor
|
Whoops, I opened a duplicate issue and sent a duplicate pull request on this, so count me in as well. |
Contributor
|
The module is meant to call async functions. Your function(n, callback) {
count += n;
callback();
}is not async, thus incompatible. |
Owner
|
Yes, making functions asynchronous is left up to the developer |
Contributor
|
OK, I understand that logic. There's a performance penalty imposed by each call to setImmediate too, so it would be redundant extra slowness for functions that are already asynchronous. |
This was referenced Jan 11, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async.eachSeries causes stack overflows for large lists.
Before:
After: