Fixed HighLimit and LowLimit for SIGNED values in EDS #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af-silva
reviewed
Feb 22, 2023
|
Sure, I thought I wrote this fix without type hints, but in the function header I forgot them. (habbits don't die easily) |
samsamfire
pushed a commit
to samsamfire/canopen
that referenced
this pull request
Mar 15, 2023
…#345) * Fixed incorrect min (LowLImit) and max (HighLimit) values when using signed integer types. * Fixed min/max for non-signed datatypes and added tests * Removed type hints
lamuguo
reviewed
Aug 31, 2023
| self.assertEqual(uint8.min, 2) | ||
| self.assertEqual(uint8.max, 10) | ||
| int32 = self.od[0x3030] | ||
| self.assertEqual(int32.min, -2147483648) |
There was a problem hiding this comment.
int32.min should be -1 in my understanding.
There was a problem hiding this comment.
You are correct. I don't know why I didn't see it. This should be the correct function:
def _signed_int_from_hex(hex_str, bit_length):
number = int(hex_str, 0)
max_value = (1 << (bit_length - 1)) - 1
if number > max_value:
return number - (1 << bit_length)
else:
return numberI will commit a full fix with correct tests in the evening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values have been interpreted as unsigned values and therefore valid values raised warnings.