Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/nested/manual/minimal-smoke: revert back to 384M for unencrypted case #11260

Conversation

anonymouse64
Copy link
Contributor

@anonymouse64 anonymouse64 commented Jan 14, 2022

Revert #11259 once the situation is resolved/understood.

See also https://bugs.launchpad.net/snapd/+bug/1954545

@anonymouse64 anonymouse64 added Simple 😃 A small PR which can be reviewed quickly Run nested The PR also runs tests inluded in nested suite ⛔ Blocked labels Jan 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #11260 (36b7f2d) into master (3ab23ac) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11260   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files         933      933           
  Lines      107868   107868           
=======================================
+ Hits        84590    84597    +7     
+ Misses      18031    18027    -4     
+ Partials     5247     5244    -3     
Flag Coverage Δ
unittests 78.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
overlord/ifacestate/handlers.go 65.02% <0.00%> (+0.14%) ⬆️
store/cache.go 71.15% <0.00%> (+1.92%) ⬆️
osutil/synctree.go 79.24% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab23ac...36b7f2d. Read the comment docs.

@anonymouse64 anonymouse64 force-pushed the bugfix/revert-min-memory-fde-smoke branch from 33520e0 to 36b7f2d Compare March 4, 2022 00:43
…ypted case too"

This reverts commit 35ff2d2.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 force-pushed the bugfix/revert-min-memory-fde-smoke branch from 36b7f2d to eda264c Compare March 17, 2022 14:23
@ernestl
Copy link
Collaborator

ernestl commented Feb 28, 2024

@sergio-costas advised that this work was completed elsewhere and documented: https://ubuntu.com/core/docs/system-requirements. Closing.

@ernestl ernestl closed this Feb 28, 2024
@sergio-costas
Copy link
Contributor

@ernestl Maybe you meant @sergiocazzolato ? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔ Blocked Run nested The PR also runs tests inluded in nested suite Simple 😃 A small PR which can be reviewed quickly Test Robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants