Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/nested/manual/minimal-smoke: bump mem to 512 for unencrypted case too #11259

Merged
merged 1 commit into from
Jan 18, 2022
Merged

tests/nested/manual/minimal-smoke: bump mem to 512 for unencrypted case too #11259

merged 1 commit into from
Jan 18, 2022

Conversation

anonymouse64
Copy link
Contributor

@anonymouse64 anonymouse64 commented Jan 14, 2022 •
edited
Loading

This needs more investigation, but for now to get test coverage again, bump it
to 512M.

See also https://bugs.launchpad.net/snapd/+bug/1954545

@anonymouse64
tests/nested/manual/minimal-smoke: bump mem to 512 for unencrypted ca…
35ff2d2 
…se too

This needs more investigation, but for now to get test coverage again, bump it
to 512M.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 added Simple 😃 A small PR which can be reviewed quickly Run nested The PR also runs tests inluded in nested suite labels Jan 14, 2022
@anonymouse64 anonymouse64 mentioned this pull request Jan 14, 2022
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #11259 (35ff2d2) into master (228aa86) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11259   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files         924      924           
  Lines      105436   105436           
=======================================
+ Hits        82606    82607    +1     
  Misses      17689    17689           
+ Partials     5141     5140    -1
Flag Coverage Δ
unittests 78.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daemon/api_connections.go 93.04% <0.00%> (-0.54%) ⬇️
store/cache.go 71.15% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228aa86...35ff2d2. Read the comment docs.

miguelpires
miguelpires approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bboozzoo
bboozzoo approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bboozzoo bboozzoo merged commit 33a68ba into canonical:master Jan 18, 2022
@anonymouse64 anonymouse64 deleted the bugfix/min-memory-fde-smoke branch January 18, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboozzoo bboozzoo bboozzoo approved these changes

@miguelpires miguelpires miguelpires approved these changes

Assignees
No one assigned
Labels
Run nested The PR also runs tests inluded in nested suite Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonymouse64 @codecov-commenter @bboozzoo @miguelpires