Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set lzo compression by default in kde-neon extension #3595

Merged
merged 1 commit into from
Mar 18, 2022
Merged

set lzo compression by default in kde-neon extension #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
kde extension: use lzo compression
  • Loading branch information
@jriddell @sergiusens
jriddell authored and sergiusens committed Mar 18, 2022
commit 4cd4173c1c3ee2a8f64b8ced5994c7488c4f2bac
1 change: 1 addition & 0 deletions snapcraft/internal/project_loader/_extensions/kde_neon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def __init__(self, *, extension_name: str, yaml_data: Dict[str, Any]) -> None:
info = _Info[yaml_data["base"]]
self.root_snippet = {
"assumes": ["snapd2.43"], # for 'snapctl is-connected'
"compression": "lzo",
"plugs": {
"desktop": {"mount-host-font-cache": False},
"icon-themes": {
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/project_loader/extensions/test_kde_neon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def test_extension_core18():

assert kde_neon_extension.root_snippet == {
"assumes": ["snapd2.43"],
"compression": "lzo",
"plugs": {
"desktop": {"mount-host-font-cache": False},
"icon-themes": {
Expand Down Expand Up @@ -76,6 +77,7 @@ def test_extension_core20():

assert kde_neon_extension.root_snippet == {
"assumes": ["snapd2.43"],
"compression": "lzo",
"environment": {"SNAP_DESKTOP_RUNTIME": "$SNAP/kf5"},
"hooks": {
"configure": {
Expand Down