-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set lzo compression by default in kde-neon extension #3595
set lzo compression by default in kde-neon extension #3595
Conversation
Is this something we still want to do? Electron-builder switch to LZO by default, too. |
sorry @ppd for the delays, let's do this |
want me to finalize the PR? |
@jriddell ping |
@igorljubuncic maybe you want to quickly profile the performance gains of switching to lzo for kde apps (the heavy and light ones)? |
Yes, this would be a useful test! |
@igorljubuncic The same idea would apply well to Gnome-based snaps. They could also be compressed as LZO by default. Furthermore, what about compressing the platform snaps as LZO? The kde platform snaps switched to LZO and saw read performance gains, which propagated through to the app snaps. This could be a rather cheap "make desktop snaps fast" initiative. |
kblocks gcompris |
kde-frameworks-5-qt-5-15-3-core20 |
If you don't mind, I am going to prep this PR for release |
0693c2c
to
10c69fb
Compare
10c69fb
to
4cd4173
Compare
Codecov Report
@@ Coverage Diff @@
## main #3595 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 278 278
Lines 19396 19396
=======================================
Hits 17699 17699
Misses 1697 1697
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…sion-lzo kde extension: use lzo compression
…sion-lzo kde extension: use lzo compression
…sion-lzo kde extension: use lzo compression
…sion-lzo kde extension: use lzo compression
./runtests.sh static
?./runtests.sh tests/unit
?enable lzo compression in kde-neon extension by default
from chatting with ppd and post at https://forum.snapcraft.io/t/lzo-for-platform-snaps/27501