feat: dynamic sidebar content #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
previously approved these changes
Aug 31, 2022
agathanatasha
previously approved these changes
Sep 2, 2022
|
Libraries are not up to date with their remote counterparts. If this was stdoutstderr |
|
There is a current effort for designing and implementing the dynamic sidebar feature, which will introduce some changes that will likely be incompatible with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this jira task and this feature
In
kubeflow-dashboard-operatorthere is asidebarrelation. In order to add element to the sidebar proper relation needs to be established. After the relation is set, charms fills the config for given app-name.Sidebar element is removed after the relation is broken.