Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dynamic content for the sidebar (config.json) driven by relations rather than the default static version #8

Closed
ca-scribner opened this issue Oct 8, 2021 · 1 comment · Fixed by #134
Labels
23.10 Should be fixed by 23.10 enhancement New feature or request

Comments

@ca-scribner
Copy link
Contributor

ca-scribner commented Oct 8, 2021

The sidebar content (links to Notebooks, Experiments, ...) is defined statically in src/config.json, which gets deployed as a configmap. These links will exist regardless of whether the associated component exists, and must be defined based on our best guess of what features kubeflow will be deployed with. If users add/remove features, they either have to fork the charm, modify the configmap themselves after deploy, or use the dashboard-configmap charm config option to point at a different configmap.

Using relations, we could allow dashboards to subscribe into the central dashboard and the dashboard can reflect what is deployed right now. Something like juju relate kubeflow-dashboard:menuLinks kfp-ui:menuLinks, which would trigger an update to the configmap. This would let the dashboard reflect this particular user's deployment easily and be a nice advantage of a charmed kubeflow.

Downsides/complications I can think of to this:

  • ordering of links might get a little odd as it could change
  • adds several relations (katib, pipelines, notebooks, volumes, etc., all need to relate to this charm)
  • technically the links would only work if the subscribing dashboard has also subscribed to istio ingress (otherwise the link will be dead), but I guess that's just as bad as if a charm subscribes with a broken link?
@DnPlas
Copy link
Contributor

DnPlas commented Aug 10, 2022

Fixed by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.10 Should be fixed by 23.10 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants