Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic sidebar content #8

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

misohu
Copy link
Member

@misohu misohu commented Jul 27, 2022

Related to this jira task and this feature

In kubeflow-dashboard-operator there is a sidebar relation with the src/extra_config.json. In order to add element to the sidebar proper relation needs to be established. After the relation is set, charms fills the config for given app-name from src/extra_config.json and reloads the configmap. Currently supporting (juju application names)

  • katib-ui for katib
  • tensorboards-web-app for tesorboard

Sidebar element is removed after the relation is broken.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.grafana_k8s.v0.grafana_dashboard updated to version 0.13.
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.20.

stderr

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu

@DnPlas DnPlas merged commit 5050697 into main Aug 31, 2022
@DnPlas DnPlas deleted the hucko-dynamic-sidebar-content branch August 31, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants