[settings] Add configurable default image#4793
Open
Jotanune wants to merge 5 commits intocanonical:mainfrom
Open
[settings] Add configurable default image#4793Jotanune wants to merge 5 commits intocanonical:mainfrom
Jotanune wants to merge 5 commits intocanonical:mainfrom
Conversation
Without this explicit dependency, vcpkg attempts to build gRPC before OpenSSL on Windows, causing the build to fail if OpenSSL is not installed system-wide.
Read the configured default image from the local.default-image setting when no image is specified in a launch request. Falls back to default (latest LTS) when the setting is empty.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2653
Summary
Add a new
local.default-imagesetting that allows users to configure which image is launched by default when no image is specified inmultipass launch.Problem
Currently,
multipass launchwithout an image argument always defaults to the latest Ubuntu LTS (via the hardcoded"default"alias). There is no way to change this behavior.Solution
local.default-imagesetting key inconstants.hBasicSettingSpecwith an empty default value in the daemonquery_from()andmake_cloud_init_vendor_config()to use the configured image when no image is specified in a launch request"default"(latest LTS) when the setting is emptyUsage
Testing
daemonRegistersPersistentHandlerForDaemonSettingsto verify the new setting is registered with an empty default valueTestGlobalSettingsHandlerstests pass