[build] Add openssl dep to grpc overlay port#4792
Closed
Jotanune wants to merge 1 commit intocanonical:mainfrom
Closed
[build] Add openssl dep to grpc overlay port#4792Jotanune wants to merge 1 commit intocanonical:mainfrom
Jotanune wants to merge 1 commit intocanonical:mainfrom
Conversation
Without this explicit dependency, vcpkg attempts to build gRPC before OpenSSL on Windows, causing the build to fail if OpenSSL is not installed system-wide.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gRPC overlay port in 3rd-party/vcpkg-ports/grpc/vcpkg.json does not list openssl as a dependency. On Windows, where OpenSSL is not available system-wide, this causes vcpkg to attempt building gRPC before OpenSSL is installed, resulting in a build failure.
This adds "openssl" to the dependencies array in the gRPC overlay port manifest, ensuring vcpkg resolves and installs OpenSSL before building gRPC.