feat: Add a secret to use with seldon deployments #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return _b64_encode_dict(minio_credentials) | ||
|
|
||
|
|
||
| def _seldon_credentials_dict(obj_storage): |
There was a problem hiding this comment.
how does do the seldon-init containers get these credentials? Specially when the seldon deployment is in a different namespace.
There was a problem hiding this comment.
For now, only with some extra steps :( There's more context in this comment. This is more a stop-gap fix until we have a way of injecting secrets into everyone's namespaces.
This first step was decided on with @Barteus so that:
- for deployments with Seldon and MLFlow in the same namespace,
SeldonDeployments work easily by referencing this secret directly - for deployments with Seldon and MLFlow in different namespaces,
SeldonDeployments cannot reference this secret directly but at least there's a "template" secret in mlflow's namespace that is easy to copy as needed
As soon as we can inject secrets into user namespaces, we remove this secret.
After talking with @Barteus, this secret means if seldon
DomFleischmann
approved these changes
Mar 18, 2022
|
Looks good, can you resolve the conflict @ca-scribner ? |
Fixes #26. Charm creates a secret with mlflow's s3 credentials called `{charm_name}-seldon-init-container-s3-credentials`. This secret is formatted as needed for a [Seldon Deployment Init Container](https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html#create-a-secret-containing-the-environment-variables). Also: * adds tests for the new secret * refactors some secret creation to make the main function of the charm read easier * removes an unused dependency from requirements.txt
ca-scribner
force-pushed
the
KF-219-bugfix-for-mlflow-seldon-secrets
branch
from
d4ae2e2
to
39a3726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26. Charm creates a secret with mlflow's s3 credentials called
{charm_name}-seldon-init-container-s3-credentials. This secret is formatted as needed for a Seldon Deployment Init Container.Also: