Add/update seldon-init-container-secret for seldon
#26
Labels
enhancement
New feature or request
Comments
ca-scribner
added a commit
that referenced
this issue
Mar 2, 2022
Fixes #26. Charm creates a secret with mlflow's s3 credentials called `{charm_name}-seldon-init-container-s3-credentials`. This secret is formatted as needed for a [Seldon Deployment Init Container](https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html#create-a-secret-containing-the-environment-variables). Also: * adds tests for the new secret * refactors some secret creation to make the main function of the charm read easier * removes an unused dependency from requirements.txt
ca-scribner
added a commit
that referenced
this issue
Mar 18, 2022
Fixes #26. Charm creates a secret with mlflow's s3 credentials called `{charm_name}-seldon-init-container-s3-credentials`. This secret is formatted as needed for a [Seldon Deployment Init Container](https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html#create-a-secret-containing-the-environment-variables). Also: * adds tests for the new secret * refactors some secret creation to make the main function of the charm read easier * removes an unused dependency from requirements.txt
ca-scribner
added a commit
that referenced
this issue
Mar 18, 2022
Fixes #26. Charm creates a secret with mlflow's s3 credentials called `{charm_name}-seldon-init-container-s3-credentials`. This secret is formatted as needed for a [Seldon Deployment Init Container](https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html#create-a-secret-containing-the-environment-variables). Also: * adds tests for the new secret * refactors some secret creation to make the main function of the charm read easier * removes an unused dependency from requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in more detail here
The
seldon-init-container-secretcan be used bySeldonDeployments to provide credentials for pulling models out of s3 storage. This secret was previously implemented in the mlflow charm as a convenience to make using seldon deployments easier, but the naming convention of the secrets did not match the current seldon init-containers expectations and it had been removed in #22.Proposed here is that we add the
seldon-init-container-secretback in with updated formatting to match Seldon's expectations (see seldondocs or this issue for details). Naming may be changed to assure uniqueness and reduce confusion (seldon-init-container-secretimplies it might have been created by seldon, not for seldon)The text was updated successfully, but these errors were encountered: