-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone sidecar charm #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…standalone-sidecar-charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor stuff, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @misohu, I think there are a few comments that we can resolve in a separate PR as this one is already very complex and convoluted. Please make sure to resolve the conversations of the status before we merge your dev branch into main.
Deploy MLflow as a sidecar charm (without any relation).
MLflow is running and is exposed as NodePort on port speciffied in config.
This is a follow up PR on #103 (first review the 103).
Publish charm will fail as it is merging agains feature branch not main (but it works on main check this draft pr against main with the same code)