-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI in AWS EC2 instance #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @misohu, few comments.
Don't refactor the current PR, but for a future thought my first impression here is I see both CI changes (aws stuff) and repo structure changes (moving charm from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes. Also, should integration tests be failing during charm build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(deleted)
The CI uses this action which will create a ec2 instance which was created for the AWS service account (kubeflow-team). All the AWS credentials and GH PAT are part of the secrets (go to settings -> secrets and variables -> actions). All the AWS EC2 configuration is part of the repo variables (go to settings -> secrets and variables -> actions).
CI uses custom AMI created from ubuntu LTS 20.04 AMI and installing docker inside. The AMI is part of the service account private AMI list (its the value set in environment variables).
Publish charm will fail as it is merging agains feature branch not main (but it works on main check this draft pr against main with the same code)