Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: set minimum size requirement to 1G" #117

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Mar 9, 2023

This reverts commit 981ad49.

@DnPlas DnPlas requested a review from a team as a code owner March 9, 2023 14:39
@DnPlas DnPlas changed the base branch from main to track/ckf-1.7 March 9, 2023 15:17
@ca-scribner
Copy link
Contributor

This change reverts the fix implemented to address #78. We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path.

@ca-scribner ca-scribner merged commit 4ff7f61 into track/ckf-1.7 Mar 9, 2023
@ca-scribner ca-scribner deleted the dnplas-revert-min-size branch March 9, 2023 15:25
DnPlas added a commit that referenced this pull request Mar 9, 2023
…117)

This reverts commit 981ad49, which solved #78.  
We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path
ca-scribner pushed a commit that referenced this pull request Mar 9, 2023
…117) (#118)

This reverts commit 981ad49, which solved #78.  
We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants