Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum requirement for Minio storage (10GB) is too much for gateway mode. #78

Open
Barteus opened this issue Dec 12, 2022 · 4 comments
Open

Minimum requirement for Minio storage (10GB) is too much for gateway mode. #78

Barteus opened this issue Dec 12, 2022 · 4 comments
Assignees
@i-chvets
Labels
bug Something isn't working

Comments

@Barteus
Copy link
Contributor

Barteus commented Dec 12, 2022

I suggest removing this requirement from storage because for Minio in gateway mode this storage is not used at all.

minio-operator/metadata.yaml

Line 30 in 429a152

minimum-size: 10G

@i-chvets i-chvets added the bug Something isn't working label Jan 4, 2023
@i-chvets
Copy link
Contributor

i-chvets commented Jan 4, 2023

Added to be fixed.

i-chvets pushed a commit that referenced this issue Jan 4, 2023
fix: remove minimum size requirements
835c842 
#78

Summary of changes:
- Removed minimum size requirements from metadata.yaml
@i-chvets i-chvets mentioned this issue Jan 4, 2023
Closed
i-chvets pushed a commit that referenced this issue Jan 4, 2023
fix: updated libraries
a1fee0d 
#78

Summary of changes:
- Updated libraries
i-chvets pushed a commit that referenced this issue Jan 4, 2023
fix: fixed tests
81152b0 
#78

Summary of changes:
- Fixed tests to match update library and ops.
- Modified tox.ini to ignore appropriate directories.
@i-chvets i-chvets self-assigned this Jan 4, 2023
@i-chvets i-chvets mentioned this issue Jan 4, 2023
Merged
i-chvets pushed a commit that referenced this issue Jan 4, 2023
fix: set minimum size requirement to 1G
981ad49 
#78

Summary of changes:
- Setting minimum size requirements to 1G (from 10G). Without
  `minimum-size` set PVS of 1G is created. Leaving minimum specification
equal to default.
@i-chvets
Copy link
Contributor

i-chvets commented Jan 4, 2023 •
edited
Loading

Without minimum-size set PVS of 1G is created. Leaving minimum specification in and setting it to default of 1G.

@i-chvets
Copy link
Contributor

i-chvets commented Jan 4, 2023

Fix is merged.

@i-chvets i-chvets closed this as completed Jan 4, 2023
@ca-scribner ca-scribner mentioned this issue Mar 9, 2023
Merged
ca-scribner pushed a commit that referenced this issue Mar 9, 2023
@DnPlas
Revert "fix: set minimum size requirement to 1G", set minimum to 10G (#…
4ff7f61 
…117)

This reverts commit 981ad49, which solved #78.  
We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path
@ca-scribner
Copy link
Contributor

Reopening because we've decided to revert the change that addressed this. See #117 for more details

@ca-scribner ca-scribner reopened this Mar 9, 2023
DnPlas added a commit that referenced this issue Mar 9, 2023
@DnPlas
Revert "fix: set minimum size requirement to 1G", set minimum to 10G (#…
7365765 
…117)

This reverts commit 981ad49, which solved #78.  
We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path
@DnPlas DnPlas mentioned this issue Mar 9, 2023
Merged
ca-scribner pushed a commit that referenced this issue Mar 9, 2023
@DnPlas
Revert "fix: set minimum size requirement to 1G", set minimum to 10G (#…
ec7d3c7 
…117) (#118)

This reverts commit 981ad49, which solved #78.  
We have reverted this because it causes trouble with the upgrade path of the charm. juju will not let you refresh a charm if the storage minimum size has changed between revisions. Because of this, we'll leave the larger minimum storage size in order to preserve the upgrade path
@ca-scribner ca-scribner mentioned this issue Mar 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i-chvets i-chvets

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Barteus @ca-scribner @i-chvets