Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the dynamic sidebar links (menuLinks) to be extendable to control all dashboard links #130

Merged
merged 4 commits into from
Jul 12, 2023
Merged

refactor the dynamic sidebar links (menuLinks) to be extendable to control all dashboard links #130

merged 4 commits into from
Jul 12, 2023

Commits on Jul 11, 2023

  1. refactor: rename SidebarItem and side nomenclature 

    * Changes the library from SidebarItems to DashboardLinks (to make it easier to extend the lib to manage other link types)
* Changes the library to use Dashboard nomenclature
* Refactors charm and tests to use new library
* Renames any existing sidebar_items to menu_links
    @ca-scribner
    ca-scribner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ed6caf8 View commit details
    Browse the repository at this point in the history

  2. refactor: extend menuLink tooling to be reusable 

    * Takes the existing menuLink (previously, sidebar) tooling in the charm and extracts it into a generic dashboard_links.py file that is link-type agnostic.
* reimplements the menuLinks using the new link-type agnostic tooling
* updates tests to new structure
    @ca-scribner
    ca-scribner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a20c308 View commit details
    Browse the repository at this point in the history

  3. remove deprecated dashboard links test

    @ca-scribner
    ca-scribner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    92910a3 View commit details
    Browse the repository at this point in the history

  4. docs: add missing docstrings.

    @ca-scribner
    ca-scribner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    71e3fd1 View commit details
    Browse the repository at this point in the history