refactor the dynamic sidebar links (menuLinks) to be extendable to control all dashboard links #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes the library from SidebarItems to DashboardLinks (to make it easier to extend the lib to manage other link types) * Changes the library to use Dashboard nomenclature * Refactors charm and tests to use new library * Renames any existing sidebar_items to menu_links
* Takes the existing menuLink (previously, sidebar) tooling in the charm and extracts it into a generic dashboard_links.py file that is link-type agnostic. * reimplements the menuLinks using the new link-type agnostic tooling * updates tests to new structure
NohaIhab
reviewed
Jul 11, 2023
Comment on lines
+16
to
+18
| def aggregate_links( | ||
| links_from_relation: List[DashboardLink], additional_link_config: str, link_order_config: str | ||
| ): |
There was a problem hiding this comment.
docstring missing here, same for the method below
ca-scribner
merged commit f211207
into
kf-3664-dynamic-sidebar-feature-branch
6 checks passed
ca-scribner
added a commit
that referenced
this pull request
Jul 12, 2023
…ntrol all dashboard links (#130) Takes the existing sidebar implementation (for dashboard `menuLinks`) and refactors it to be easily extended to all kubeflow dashboard link types (menu, external, quick, and documentation). * Changes the library from SidebarItems to DashboardLinks (to make it easier to extend the lib to manage other link types) * Changes the library to use Dashboard nomenclature * Refactors charm and tests to use updated library * Renames any existing sidebar_items to menu_links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing dynamic dashboard implementation to make it more easily reused with other dashboard link types.
changes include:
The general function of the charm shouldn't change, just the implementation.
Notes to reviewers: