Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging relation to kserve-controller #249

Closed

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Jul 8, 2024

Use LogForwarder from loki_push_api library to forwards all logs from workload container to Loki. This requires to use ops 2.9 or newer, so it was needed to be updated.

fixes: #236

How I tested it:

# deployed the cos following https://charmhub.io/topics/canonical-observability-stack/tutorials/install-microk8s
$ tox -e integration -- --keep-models --model kubeflow
$ juju switch kubeflow
$ charmcraft pack
Created 'oidc-gatekeeper_ubuntu-20.04-amd64.charm'.

Charms packed:

    oidc-gatekeeper_ubuntu-20.04-amd64.charm
# need to refresh back to local build of charm
$ juju refresh oidc-gatekeeper --path ./oidc-gatekeeper_ubuntu-20.04-amd64.charm 
Added local charm "oidc-gatekeeper", revision 1, to the model
adding endpoint "logging" to default space "alpha"
no change to endpoints in space "alpha": client-secret, ingress, ingress-auth, oidc-client
$ juju consume u1-k8s:cos.loki-logging
$ juju integrate grafana-agent-k8s loki-logging
$ juju integrate oidc-gatekeeper:logging grafana-agent-k8s 

And after checking the Grafana, I was able to see all logs.
Screenshot from 2024-07-09 00-40-17

Use LogForwarder from loki_push_api library to forwards all logs from
workload container to Loki. This requires to use ops 2.9 or newer, so it
was needed to be updated.

fixes: canonical#236
@rgildein rgildein added the enhancement New feature or request label Jul 8, 2024
@rgildein rgildein self-assigned this Jul 8, 2024
@rgildein rgildein requested a review from a team as a code owner July 8, 2024 22:47
@rgildein rgildein closed this Jul 8, 2024
@rgildein rgildein deleted the feat/KF-5799/log-forwarding branch July 8, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging relation to kserve-controller charm
1 participant