Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging relation to kserve-controller charm #236

Closed
rgildein opened this issue Jun 3, 2024 · 1 comment · Fixed by #250
Closed

Add logging relation to kserve-controller charm #236

rgildein opened this issue Jun 3, 2024 · 1 comment · Fixed by #250
Labels
enhancement New feature or request

Comments

@rgildein
Copy link
Contributor

rgildein commented Jun 3, 2024

Context

Add logging relation using loki_push_api interface and LogForwarder to kserve-controller charm. Alternatively the LogProxyConsumer, could be used if the service is using log file instead of STDOUT, however this needs to be discussed because LogProxyConsumer is marked as deprecated.

This task is part of the COS integration initiative for all Kubeflow charms.

What needs to get done

  1. Add logging relation using loki_push_api interface
  2. Use LogForwarder or LogProxyConsumer
  3. Use chisme abstraction for testing

Definition of Done

  1. Charm could be related with grafana-agent-k8s via logging relation
  2. This relation was tested by integration tests
  3. This relation was tested manually with COS deployed
@rgildein rgildein added the enhancement New feature or request label Jun 3, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5799.

This message was autogenerated

rgildein added a commit to rgildein/kserve-operators that referenced this issue Jul 8, 2024
@rgildein
Add logging relation to kserve-controller
ca543c3 
Use LogForwarder from loki_push_api library to forwards all logs from
workload container to Loki. This requires to use ops 2.9 or newer, so it
was needed to be updated.

fixes: canonical#236
This was referenced Jul 8, 2024
Closed
Merged
@rgildein rgildein mentioned this issue Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@rgildein