Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set automatically-retry-hooks to false #204

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Feb 5, 2024

By default, Juju automatically retries any failed hook (any event that raises an uncaught exception). This is often helpful, but in our CI it might hide transient errors that we would want to fix. We should disable this behavior in our test environment.

closes #202

should be merged after #203

@NohaIhab NohaIhab requested a review from a team as a code owner February 5, 2024 08:29
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimwnasptd kimwnasptd force-pushed the ci-automatic-retry-hooks-false branch from 11ab802 to 4e0d7ce Compare February 8, 2024 09:23
@kimwnasptd kimwnasptd merged commit 78b403f into main Feb 8, 2024
7 checks passed
@kimwnasptd kimwnasptd deleted the ci-automatic-retry-hooks-false branch February 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Juju's automatic retry for error'd events in CI
3 participants