Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use manifests charm lib for relation handling #203

Merged
merged 4 commits into from
Feb 8, 2024
Merged

feat: use manifests charm lib for relation handling #203

merged 4 commits into from
Feb 8, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Feb 1, 2024 •
edited
Loading

closes #201

  • reuses the kubernetes_manifests library from resource dispatcher to handle the service-accounts and secrets relation
  • removes the duplicate unit test test_send_manifests that is tested extensively in the library unit tests

@NohaIhab NohaIhab requested a review from a team as a code owner February 1, 2024 14:26
orfeas-k
orfeas-k previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NohaIhab. Left 2 nit comments

charms/kserve-controller/src/charm.py Outdated Show resolved Hide resolved
charms/kserve-controller/tests/unit/test_charm.py Outdated Show resolved Hide resolved
@NohaIhab NohaIhab mentioned this pull request Feb 6, 2024
Merged
orfeas-k
orfeas-k approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NohaIhab, approved!

@kimwnasptd kimwnasptd merged commit 660740c into main Feb 8, 2024
7 checks passed
@kimwnasptd kimwnasptd deleted the kf-5196-feat-use-manifests-lib branch February 8, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-write the relation handling using resource dispatcher charm lib
3 participants
@NohaIhab @orfeas-k @kimwnasptd