Skip to content

fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: feat/process-instance-diagram
Choose a base branch
from
Draft

fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2921720
Initial plan
Copilot Feb 23, 2026
b2b720c
fix: use t.skip() instead of assert.ok(true) when Chrome is not insta…
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/integration/process-instances.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ describe('Process Instance Integration Tests (requires Camunda 8 at localhost:80
}
});

test('get process instance with --diagram flag without --output prints inline', async () => {
test('get process instance with --diagram flag without --output prints inline', async (t) => {
// Deploy and create a process instance
await deploy(['tests/fixtures/simple.bpmn'], {});
const result = await createProcessInstance({
Expand All @@ -209,10 +209,9 @@ describe('Process Instance Integration Tests (requires Camunda 8 at localhost:80
assert.ok(output.includes('\x1b]1337;File='), 'Output should contain iTerm2 inline image protocol');
assert.ok(output.includes('inline=1'), 'Output should indicate inline display mode');
} catch (error: any) {
// On systems without Chrome/Chromium, this test may fail
// Verify it fails with a helpful error message
// On systems without Chrome/Chromium, skip the test rather than silently passing
if (error.stderr && error.stderr.includes('No Chrome or Chromium browser found')) {
assert.ok(true, 'Test skipped: Chrome/Chromium not installed');
t.skip('Chrome/Chromium not installed');
} else {
throw error;
}
Expand Down