Skip to content

Comments

fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test#80

Draft
Copilot wants to merge 2 commits intofeat/process-instance-diagramfrom
copilot/sub-pr-60
Draft

fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test#80
Copilot wants to merge 2 commits intofeat/process-instance-diagramfrom
copilot/sub-pr-60

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

The inline diagram integration test silently passed as green when Chrome/Chromium was not installed, masking the fact that the actual rendering logic was never exercised.

Change

  • Updated test callback to accept t (TestContext) and replaced assert.ok(true, 'Test skipped: ...') with t.skip('Chrome/Chromium not installed')
- test('get process instance with --diagram flag without --output prints inline', async () => {
+ test('get process instance with --diagram flag without --output prints inline', async (t) => {
    ...
    } catch (error: any) {
-     if (error.stderr && error.stderr.includes('No Chrome or Chromium browser found')) {
-       assert.ok(true, 'Test skipped: Chrome/Chromium not installed');
+     if (error.stderr && error.stderr.includes('No Chrome or Chromium browser found')) {
+       t.skip('Chrome/Chromium not installed');
      } else {
        throw error;
      }
    }

In CI without Chrome, this test now reports as skipped rather than passed, making the test suite results accurate.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…lled in diagram test

Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP to address feedback from PR #60 on PI diagram rendering fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test Feb 23, 2026
Copilot AI requested a review from vobu February 23, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants