fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test#80
Draft
Copilot wants to merge 2 commits intofeat/process-instance-diagramfrom
Draft
fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test#80Copilot wants to merge 2 commits intofeat/process-instance-diagramfrom
Copilot wants to merge 2 commits intofeat/process-instance-diagramfrom
Conversation
…lled in diagram test Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback from PR #60 on PI diagram rendering
fix: use t.skip() instead of assert.ok(true) when Chrome is unavailable in diagram test
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline diagram integration test silently passed as green when Chrome/Chromium was not installed, masking the fact that the actual rendering logic was never exercised.
Change
t(TestContext) and replacedassert.ok(true, 'Test skipped: ...')witht.skip('Chrome/Chromium not installed')In CI without Chrome, this test now reports as skipped rather than passed, making the test suite results accurate.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.